Repository navigation
Fix OTA manifest lambda for ESPHome dev - #129
Conversation
Release 26.7.23.1 - Firmware update channels, sen5x model fix, API encryption
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. WalkthroughThe default ESPHome firmware version changes to ChangesESPHome firmware and OTA updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The OTA manifest selection remains unchanged, and the selected URL is compatible with the inspected ESPHome API. No actionable merge-blocking risk is established in these changes. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the firmware line, Comment |
🤖 Generated with [Claude Code](https://claude.com/claude-code)
33e456b to
710c7c4
Compare
Version: 26.9.29.1
What does this implement/fix?
Fixes the build against ESPHome dev. esphome#19211 changed the
http_requestupdate entity'sset_source_url()to take aconst char *and keep the pointer, so passing astd::stringfails withcannot convert 'std::string' to 'const char*'.apply_ota_sourcenow picks between the two manifest URLs as string literals, which stay valid for the life of the firmware. Current stable still accepts this, since itsconst std::string ¶meter converts fromconst char *. No change in behavior.Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code
Summary by CodeRabbit