Skip to content

Fix OTA manifest lambda for ESPHome dev - #129

Merged
TrevorSchirmer merged 3 commits into
betafrom
ota-url-const-char
Oct 8, 2026
Merged

TrevorSchirmer merged 3 commits into
betafrom
ota-url-const-char

Conversation

@bharvey88

@bharvey88 bharvey88 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Version: 26.9.29.1

What does this implement/fix?

Fixes the build against ESPHome dev. esphome#19211 changed the http_request update entity's set_source_url() to take a const char * and keep the pointer, so passing a std::string fails with cannot convert 'std::string' to 'const char*'.

apply_ota_source now picks between the two manifest URLs as string literals, which stay valid for the life of the firmware. Current stable still accepts this, since its const std::string & parameter converts from const char *. No change in behavior.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Updated the default firmware version for the ESPHome integration from 26.8.27.1 to 26.10.8.1. Stable and Beta update sources remain available, and the selected source continues to be used for firmware updates. No other end-user-facing changes are included in this release.

Release 26.7.23.1 - Firmware update channels, sen5x model fix, API encryption
@bharvey88 bharvey88 added the bugfix Bug fix label Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7485b10e-39ef-4418-8c15-c72c0ebba313
📥 Commits

Reviewing files that changed from the base of the PR and between 710c7c4 and 66da0e7.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Walkthrough

The default ESPHome firmware version changes to 26.10.8.1. apply_ota_source stores and logs the selected Stable or Beta manifest URL as a const char *. The selected URL remains the update request source.

Changes

ESPHome firmware and OTA updates

Layer / File(s) Summary
Firmware default and OTA logging
Integrations/ESPHome/Core.yaml
The default firmware version changes to 26.10.8.1. apply_ota_source logs the selected manifest URL directly from a const char * and continues to set it as the update request source.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: bunton33

Merge Risk: ⚪ Minimal · up to 66da0

The OTA manifest selection remains unchanged, and the selected URL is compatible with the inspected ESPHome API. No actionable merge-blocking risk is established in these changes.

Architecture Summary

Architecture risk: 🔵 Low · up to 33e45

The change affects 1 system.

Changed systems: Integrations

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — Integrations (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in Integrations/ESPHome/Core.yaml: The default firmware version changes from 26.8.27.1 to 26.9.29.1.
  • observed — Modified behavior in Integrations/ESPHome/Core.yaml: apply_ota_source now stores the selected manifest URL as a const char * and passes it directly to the log call instead of constructing a std::string and logging its c_str(). The Stable/Beta selection remains unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing the OTA manifest lambda for ESPHome development builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the firmware line,
A newer version now will shine.
Stable or Beta, URLs flow,
Logged directly as they go.
One hop, one change, then off I bound.

Comment @coderabbitai help to get the list of available commands.

@bharvey88
bharvey88 changed the base branch from beta to main September 29, 2026 22:04
TrevorSchirmer
TrevorSchirmer previously approved these changes Sep 29, 2026
@bharvey88 bharvey88 closed this Oct 2, 2026
@TrevorSchirmer TrevorSchirmer reopened this Oct 8, 2026
@TrevorSchirmer
TrevorSchirmer changed the base branch from main to beta October 8, 2026 14:07
@TrevorSchirmer
TrevorSchirmer dismissed their stale review October 8, 2026 14:07

The base branch was changed.

@TrevorSchirmer
TrevorSchirmer merged commit c6e7e0c into beta Oct 8, 2026
13 checks passed
@TrevorSchirmer
TrevorSchirmer deleted the ota-url-const-char branch October 8, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants