Repository navigation
Switch Full Duplex Component - #4
Merged
Merged
Conversation
Replace the vendored i2s_audio (2026.9.0 + #16882 with local fixes) with 2026.9.1's i2s_audio plus the full duplex changes from #19959, the implementation on track upstream. The bus now allocates the TX/RX pair once at boot and initializes RX first, so RX drives the shared clocks and MCLK for the PCM1808. TX starts and stops with each playback session from a fresh preload, which keeps speaker timestamps exact without the old realign workaround. Only the PR's own changes are applied; its dev base needs a newer esp-audio-libs and audio_dac than 2026.9.1. Core.yaml is unchanged and already meets the PR's validation rules.
Drop the vendored i2s_audio and load full duplex straight from #19959, pinned to its head commit. The PR builds on ESPHome 2026.10, so: - min_version is now 2026.10.0b1, giving older ESPHome a clear error - build-beta.yml builds with ESPHome beta - CI and weekly checks skip stable until 2026.10.0 ships build.yml (main) stays on stable, so stable firmware can't be published on a beta ESPHome. Once #19959 ships in a release, remove the external_components block and restore stable in the workflows.
Change I2S Full Duplex Component
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (21)
💤 Files with no reviewable changes (17)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe workflows now select ESPHome beta and dev versions, and Core.yaml raises the minimum ESPHome version and pins ChangesESPHome I2S component migration
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Suggested reviewers: Merge Risk: 🔵 Low · up to The change switches the firmware to the upstream full-duplex audio component and uses beta ESPHome builds. Merging is reasonable, but the build depends on a pinned unreleased commit and beta tooling, so the owner should plan to revert those overrides once ESPHome 2026.10 ships. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the version pin, Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 26.10.8.1
What does this implement/fix?
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
Summary by CodeRabbit