Skip to content

Fix OTA manifest lambda for ESPHome dev - #107

Closed
bharvey88 wants to merge 1 commit into
betafrom
ota-url-const-char
Closed

bharvey88 wants to merge 1 commit into
betafrom
ota-url-const-char

Conversation

@bharvey88

@bharvey88 bharvey88 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Version: 26.9.29.1

What does this implement/fix?

Fixes the build against ESPHome dev. esphome#19211 changed the http_request update entity's set_source_url() to take a const char * and keep the pointer, so passing a std::string fails with cannot convert 'std::string' to 'const char*'.

apply_ota_source now picks between the two manifest URLs as string literals, which stay valid for the life of the firmware. Current stable still accepts this, since its const std::string & parameter converts from const char *. No change in behavior.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Updated the configured firmware version to 26.9.29.1.

@bharvey88 bharvey88 added the bugfix Bug fix label Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e93f71ba-4dc2-4d10-8d27-e3d9e989b27b

📥 Commits

Reviewing files that changed from the base of the PR and between 8741839 and 9ce5bfd.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The ESPHome configuration updates the firmware version from 26.8.27.1 to 26.9.29.1. The OTA source function stores the selected manifest URL as a const char * and logs it directly. Stable and Beta manifest selection remains unchanged.

Changes

ESPHome Configuration

Layer / File(s) Summary
Firmware version and OTA logging
Integrations/ESPHome/Core.yaml
The configured firmware version changes to 26.9.29.1. apply_ota_source stores the selected manifest URL as a const char * and logs it directly. Stable and Beta URL selection remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: bunton33

Merge Risk: ⚪ Minimal · up to 9ce5b

The selected OTA manifest URL remains unchanged, and the inspected Stable and dev APIs accept the updated argument. No actionable merge risk is established; normal validation remains appropriate.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing the OTA manifest lambda for ESPHome development builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the firmware line,
A manifest pointer looks just fine.
Stable and Beta keep their place,
The log records the URL with grace.
The burrow hums; the build is done.

Comment @coderabbitai help to get the list of available commands.

@bharvey88 bharvey88 closed this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant