Repository navigation
ci: fix broken CI builds on forked PRs - #134
Open
PoonHarpoon wants to merge 1 commit into
Open
PoonHarpoon wants to merge 1 commit into
PoonHarpoon wants to merge 1 commit into
Conversation
GitHub gives pull_request runs from a fork a read-only GITHUB_TOKEN, whatever the workflow asks for, so issues.createComment is refused and the job is marked failed although the APK built and was uploaded. Only comment when the branch is in this repository (and not on manual workflow_dispatch runs, which have no pull request to comment on).
Author
|
Green mark, it works, keeps good builds from not passing checks; Once this is merged I have some some more PRs to land |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes successful builds that report "failed" because they couldn't create a comment, and therefore report a total failure.
GitHub gives pull_request runs from a fork a read-only GITHUB_TOKEN,
whatever the workflow asks for, so issues.createComment is refused and
the job is marked failed although the APK built and was uploaded.
The comment step now only runs for pull requests from branches in this repository, so fork PRs still build and upload the APK but skip the comment.