Skip to content

feature/hebrew-support - #26

Open
Zigoman wants to merge 3 commits into
ArabPixel:mainfrom
Zigoman:main
Open

feature/hebrew-support#26
Zigoman wants to merge 3 commits into
ArabPixel:mainfrom
Zigoman:main

Conversation

@Zigoman

@Zigoman Zigoman commented Aug 18, 2026

Copy link
Copy Markdown

adding Hebrew support for the WebKit

@ArabPixel

Copy link
Copy Markdown
Owner

There are several issues with this Pull Request:

  • Language strings are missing, for example a lot from the customization pop-up and the credits section.
  • you added PSFree Enhanced as a title. that isn't used anymore. Also the project name has changed anyway.
  • Merge conflicts. I would suggest to just sync the repo with your fork and commit your new language file with the fixes mentioned above. you can take the changes from en.js since its always up to the date.

i just found out that i forgot to run npm run build to generate index-old.js. that would be nice to add too.

@ArabPixel

Copy link
Copy Markdown
Owner

Also since you're creating a new file this needs to be added to all manifest files for offline usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants