Repository navigation
Short-circuit empty cookie store lookups - #2261
Closed
pavel-ptashyts wants to merge 1 commit into
Closed
pavel-ptashyts wants to merge 1 commit into
pavel-ptashyts wants to merge 1 commit into
Conversation
Return an empty cookie list immediately when ThreadSafeCookieStore has no retained cookies. This avoids request host normalization, path lookup, and subdomain scanning on the common empty-jar path while preserving null handling with an explicit Uri null check. Add coverage for get(Uri) on an empty store. Verified with:\n- /opt/maven/bin/mvn -pl client -DskipTests compile\n- /opt/maven/bin/mvn -pl client -Dtest=ThreadSafeCookieStoreGetTest test
Contributor
Author
|
Closing because this performance change will not be pursued. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadSafeCookieStorehas no retained cookies.requireNonNull(uri, "uri")before the shortcut.get(Uri)on an empty store.Motivation
The default cookie store is consulted for each request. When no cookies have been stored, the lookup does not need to normalize the request host, derive the request path, or scan subdomains.
Validation
/opt/maven/bin/mvn -pl client -DskipTests compile/opt/maven/bin/mvn -pl client -Dtest=ThreadSafeCookieStoreGetTest test