Repository navigation
fix(ptz): support VISCA over UDP - #156
iibaranov-IG wants to merge 1 commit into
Conversation
|
In this case, What is required to test it? I try to use just this Fix, but I couldn't manage to install it via Python on my Windows P |
|
Thanks for checking it. This PR is not in a published package yet, so please run it from the PR branch rather than installing the current release from PyPI. On Windows with Python 3.12+: git clone --branch fix/155-visca-udp https://github.com/iibaranov-IG/autoptz.git
cd autoptz
py -3.12 -m venv .venv
.\.venv\Scripts\Activate.ps1
python tools/install.py --editable
python -m autoptzIf PowerShell blocks activation, run To test the change:
Please let me know the Vaddio model/firmware, UDP port (you can redact the IP address), whether each control moved the camera, and any log lines mentioning Thanks again — your Vaddio setup is exactly the hardware case this PR is meant to cover. |



What & why
VISCA-IP currently opens only a TCP connection, so cameras such as the Vaddio RoboSHOT 20 UHD in #155 cannot receive PTZ commands on their UDP control port. This adds an explicit TCP/UDP selector to the camera's Advanced PTZ settings while keeping TCP as the default for existing configurations.
Closes #155.
How
ptz.visca_transportastcporudpThe issue reporter can validate this on the Vaddio by selecting
visca_ip, entering the camera address and port, and choosingudpunder Advanced PTZ settings.Checklist
autoptz/config/passesTesting
Verified on Python 3.12 with fake TCP and UDP sockets. Tests assert UDP socket creation, peer selection, command bytes, whole-datagram Sony reply parsing, TCP default compatibility, factory propagation, UI persistence, reconnect behavior, stop-on-loss behavior, and config validation. Hardware validation on the reporter's Vaddio remains required.