Skip to content

Keep the name and URL of connected sites gone from WordPress.com - #5160

Merged
chubes4 merged 1 commit into
trunkfrom
fix/keep-gone-remote-details
Oct 16, 2026
Merged

chubes4 merged 1 commit into
trunkfrom
fix/keep-gone-remote-details

Conversation

@chubes4

@chubes4 chubes4 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

Claude (via the Pi coding agent in a Roadie session) found this while comparing Studio Code agent runs, traced it to the code, wrote the change and its test, and ran the verification below. Opened as a draft for human review.

Proposed Changes

  • When a connected WordPress.com site is no longer in the user's site list, withWpcomDetails marks it deleted, but it also blanks out its name and URL. Both the Studio app's connected-sites list and the agent's site_connected_remote_sites tool then show an unnamed site, so the user can't tell which connection is broken.
  • The site now keeps the name and URL it was connected under, along with its deleted status.

Testing Instructions

  • npx vitest run packages/common/lib/sync: the test now expects a gone site to keep its stored name and URL.
  • Manually: connect a site, then remove it from the account, or edit its ID in shared.json to one that doesn't exist. Its row keeps the original name and URL.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@chubes4
chubes4 marked this pull request as ready for review October 16, 2026 20:59
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 2005b7d vs trunk

app-size

Metric trunk 2005b7d Diff Change
App Size (Mac) 930.72 MB 930.72 MB 0.00 MB ⚪ 0.0%

site-editor

Metric trunk 2005b7d Diff Change
load 1153 ms 1175 ms +22 ms ⚪ 0.0%

site-startup

Metric trunk 2005b7d Diff Change
siteCreation 8582 ms 8567 ms 15 ms ⚪ 0.0%
siteStartup 5896 ms 5926 ms +30 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@chubes4
chubes4 merged commit 7e2bd27 into trunk Oct 16, 2026
14 checks passed
@chubes4
chubes4 deleted the fix/keep-gone-remote-details branch October 16, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants