Repository navigation
Keep the name and URL of connected sites gone from WordPress.com - #5160
Merged
Merged
Conversation
chubes4
marked this pull request as ready for review
October 16, 2026 20:59
Collaborator
📊 Performance Test ResultsComparing 2005b7d vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
11 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude (via the Pi coding agent in a Roadie session) found this while comparing Studio Code agent runs, traced it to the code, wrote the change and its test, and ran the verification below. Opened as a draft for human review.
Proposed Changes
withWpcomDetailsmarks itdeleted, but it also blanks out its name and URL. Both the Studio app's connected-sites list and the agent'ssite_connected_remote_sitestool then show an unnamed site, so the user can't tell which connection is broken.deletedstatus.Testing Instructions
npx vitest run packages/common/lib/sync: the test now expects a gone site to keep its stored name and URL.shared.jsonto one that doesn't exist. Its row keeps the original name and URL.Pre-merge Checklist