Skip to content

STUDIO.md: Drop the skills list that agents already discover from the installed skills - #5195

Merged
chubes4 merged 1 commit into
trunkfrom
studio/studio-md-installed-skills
Oct 20, 2026
Merged

chubes4 merged 1 commit into
trunkfrom
studio/studio-md-installed-skills

Conversation

@chubes4

@chubes4 chubes4 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

Claude (via the Pi coding agent in a Roadie session) traced how skills reach a site, found the stale list, wrote the change, and drafted this description. I reviewed the change and the reasoning.

Proposed Changes

STUDIO.md's "Available Skills" section lists six skills as installed in every site. Only the skills a user picks in Settings → Skills are installed (installAiInstructionsToSite copies just selectedSkills), and they can be added or removed later. So the list often names skills the site doesn't have, and it's the same for every site.

Agents don't need it: Claude Code finds skills in .claude/skills/ and Codex in .agents/skills/, each from the skill's own name and description, and they see exactly what's installed.

This removes the section:

  • The list goes. Agents discover the installed skills themselves.
  • The studio wp prefix note goes. It repeats the file's first section, "WP-CLI in WordPress Studio".
  • The wp-project-triage note stays, moved under "Studio-Specific Notes", since nothing else says it.

Net: 16 lines removed, 1 added. STUDIO.md is a managed file, so existing sites get the change the next time they start (updateManagedInstructionFiles).

Testing Instructions

  1. In Settings → Skills, install only Studio CLI, then create a site.
  2. Open the site's STUDIO.md: no "Available Skills" section, and the triage note sits under "Studio-Specific Notes".
  3. ls <site>/.claude/skills <site>/.agents/skills shows only studio-cli, which is what agents discover. On trunk, STUDIO.md also names the five WordPress skills that aren't there.

npx vitest run packages/common/lib/tests/agent-skills.test.ts passes (17). No eval: this file isn't loaded by Studio Code. It only reaches external agents opened in a site folder.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@chubes4
chubes4 marked this pull request as ready for review October 20, 2026 02:49
@chubes4
chubes4 merged commit 3723702 into trunk Oct 20, 2026
14 checks passed
@chubes4
chubes4 deleted the studio/studio-md-installed-skills branch October 20, 2026 02:51
chubes4 added a commit that referenced this pull request Oct 20, 2026
## Related issues

- Follows #5195: drop `STUDIO.md` instructions that repeat something
else.

## How AI was used in this PR

Claude (via the Pi coding agent in a Roadie session) found the repeated
rule, wrote the change, and drafted this description. I reviewed the
change and the reasoning.

## Proposed Changes

`STUDIO.md` says "don't edit `wp-includes/` or `wp-admin/`" five times:
in the Constraints table, twice in "Use hooks, not direct edits" (the
rule and a code comment), in "When to Create vs. Modify", and again in
"Studio-Specific Notes".

This keeps it once, in "Use hooks, not direct edits", the only place
that gives the reason (core edits are overwritten on every WordPress
update) and shows the alternative (the `add_action` example). The other
four go. That paragraph now reads as what to do: extend through hooks in
a plugin or theme, and leave core as shipped.

Net: 2 lines added, 10 removed, in `skills/STUDIO.md` only. It's a
managed file, so existing sites pick it up the next time they start
(`updateManagedInstructionFiles`).

## Testing Instructions

1. Create a site and open its `STUDIO.md`.
2. `grep -n "wp-includes" STUDIO.md` returns one line, under "Use hooks,
not direct edits".

`npx vitest run packages/common/lib/tests/agent-skills.test.ts` passes
(17). No eval: Studio Code doesn't load this file, which only reaches
external agents opened in a site folder. The rule itself is unchanged;
only its copies are removed.

## Pre-merge Checklist

- [ ] Have you checked for TypeScript, React or other console errors?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant