Skip to content

Studio: Start a site from its path in cli.json instead of listing every site first #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 4 commits into from
Oct 28, 2026
Merged

Studio: Start a site from its path in cli.json instead of listing every site first #5351

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e980b11
Studio: Start a site from its path in cli.json instead of listing eve…
chubes4 Oct 23, 2026
02023d5
Drop the startServer unit tests: the startup benchmark measures the c…
chubes4 Oct 23, 2026
cbe0e8b
Fail a start for a site cli.json doesn't have instead of doing nothing
chubes4 Oct 23, 2026
5aacf8f
Merge branch 'trunk' into app/start-without-lookup
chubes4 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions apps/studio/src/ipc-handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,9 +616,10 @@ export async function updateSite(
}

export async function startServer( event: IpcMainInvokeEvent, id: string ): Promise< void > {
const site = await getSite( id );
// Starting only needs the path, which `cli.json` has; the CLI's full details wait for a failure.
const site = await readSite( id );
if ( ! site ) {
return;
throw new Error( `Site not found: ${ id }` );
}

// Release the port held by any active PHP-error recovery before (re)starting the real server,
Expand All @@ -635,10 +636,12 @@ export async function startServer( event: IpcMainInvokeEvent, id: string ): Prom
throw error;
}

const details = await getSite( id ).catch( () => undefined );

// A fatal error in the user's own PHP (theme/plugin) code stops WordPress from booting.
// Rather than failing the start, serve the parsed PHP error on the site's port and watch for
// the fix so the site self-recovers. This is user code, not a Studio bug, so skip Sentry.
if ( isPhpUserError( error ) ) {
if ( details && isPhpUserError( error ) ) {
const processManagerLogs = readProcessManagerLogs( id );
const logContent = [
...( processManagerLogs.stdout ?? [] ),
Expand All @@ -647,19 +650,19 @@ export async function startServer( event: IpcMainInvokeEvent, id: string ): Prom
const errorMessage = parsePhpError( logContent );

try {
await startErrorRecovery( site, errorMessage, readProcessManagerLogs, start );
console.log( `[PHP Recovery - ${ id }] Serving PHP error page on port ${ site.port }` );
const url = `http://localhost:${ site.port }`;
await startErrorRecovery( details, errorMessage, readProcessManagerLogs, start );
console.log( `[PHP Recovery - ${ id }] Serving PHP error page on port ${ details.port }` );
const url = `http://localhost:${ details.port }`;
void sendIpcEventToRenderer( 'site-event', {
event: SITE_EVENTS.UPDATED,
siteId: id,
site: {
id,
name: site.name,
path: site.path,
port: site.port,
name: details.name,
path: details.path,
port: details.port,
url,
phpVersion: site.phpVersion,
phpVersion: details.phpVersion,
},
running: true,
} );
Expand All @@ -674,11 +677,11 @@ export async function startServer( event: IpcMainInvokeEvent, id: string ): Prom

const contexts: Record< string, Record< string, unknown > > = {
server: {
running: site.running,
phpVersion: site.phpVersion,
port: site.port,
hasCustomDomain: !! site.customDomain,
httpsEnabled: !! site.enableHttps,
running: details?.running,
phpVersion: details?.phpVersion,
port: details?.port,
hasCustomDomain: !! details?.customDomain,
httpsEnabled: !! details?.enableHttps,
},
};

Expand Down
Loading