Repository navigation
Studio Code: Revert active site facts and saved Site Editor copy notes - #5361
Merged
Merged
Conversation
youknowriad
marked this pull request as ready for review
October 24, 2026 13:12
Contributor
Author
|
Let's do this temporary revert while our friend @chubes4 explore an alternative architecture. |
chubes4
added a commit
that referenced
this pull request
Oct 25, 2026
Conflicts came from #5361 (the revert of active site facts and saved Site Editor copy notes) and #5372 (the apps/ui reorganization). The spike keeps its side of #5361: site-facts.ts, saved-copies.ts and their tests stay; result-notes.ts and the edit-manage-site skill stay deleted; served-tool.ts, runtimes/pi/index.ts, system-prompt.ts and tests/system-prompt.test.ts keep the spike's version, #5361 being trunk's only change to them since the merge base. The spike's one change to the old session-view conversation, dropping the inspect_design display case, is applied where #5372 moved it (features/chats/session-view/conversation/trace/tool-display.ts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code reverted both PRs, resolved the one conflict with #5333 (keeping its shared result notes), and ran lint, typecheck and the
apps/cli/aitests. I reviewed the diff.Proposed Changes
#5092 handled templates and parts saved in the Site Editor with one sentence in
edit-manage-site. #5301 replaced that sentence with Active site facts in the system prompt, and #5343 moved the saved copies into tool-result notes, backed by a SQLite reader and theme-path matching.#5343's own evals show this machinery does no better than the sentence. Both pass the saved-copy cases (template part 6/6, Global Styles 6/6), and the sentence's cost on unrelated edits was not measurable: 14.3 vs 14.1 tool calls before the first write, with tokens and wall time at parity. Meanwhile the notes only fire when a call names the exact theme file a copy replaces. They duplicate WordPress's template resolution in SQL, and they widen result notes into a hook on every call's arguments, which makes it easy to keep adding special cases that never show in tool descriptions.
This brings back the one-line guidance in
edit-manage-site, which reaches both Studio Code andstudio mcp. It also removes the Active site facts. The WordPress version was their only remaining line, andsite_infoalready reports it. #5333's block settings notes stay as they are.Testing Instructions
npx vitest run apps/cli/aipasses.npm run eval -- --filter-pattern "in the Site Editor"runs Studio Code: Apply theme template edits to Site Editor customizations instead of silently missing them #5092's two cases,template-part-db-overrideandglobal-styles-db-override. On this branch, one run each with Studio's default model (fast):In both runs the agent loaded
edit-manage-site, listed the saved copies withpost list, and edited the saved post: header post 5 withsubmenuVisibility: "click"and the tagline kept, and Global Styles post 5 with the new background and the saved line height kept. It didn't touch the theme files. This is one run per case, so it confirms the sentence still works; it doesn't measure a rate.Pre-merge Checklist
🤖 Generated with Claude Code