Repository navigation
Fix padding beside documentation sidebar borders - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps sidebar labels 10px away from their left borders, including hover and focus states. The upstream documentation template was overriding the intended padding with 0px normally and 5px on hover.
A narrowly scoped CSS override fixes the cascade without changing typography, active styling or nested indentation. The layout check now rejects collapsed sidebar padding; tooling instructions and the Unreleased changelog are updated.
Verification
Guide and API pages passed six mobile/desktop/wide layout checks and 36 normal/hover/focus measurements. Screenshots confirm spacing for nested and current-page items. Removing the override reproduces the reset and fails the regression guard. Both independent reviews found no issues.
Documentation build, links and snippets passed. Merging triggers the existing Spacefast documentation workflow; no library release is involved.
Validation details
c4579a396fc66923ef49d72f79d7b8abfb2b44d4; commitcd6202be5ae314936032378f0843364d2f2bfb7f. All 12 reviewed source/support content/mode/absence fingerprints are preserved after commit, with a clean worktree.php tools/docs/build.phpand generated-page checks passed for 1,606 HTML pages; example checks passed 35 PHP fragments with synthetic tutorial/migration reads; 495 repository Markdown links passed. Generated-page/snippet/link checks and diff hygiene were renewed after the content-identical commit.git diff --checkpassed. Zero PHPUnit tests or runtime-library files changed; no full-library suite rerun is claimed.