Skip to content

Fix padding beside documentation sidebar borders - #64

Merged
SirDarcanos merged 1 commit into
mainfrom
fix/docs-sidebar-padding
Oct 21, 2026
Merged

SirDarcanos merged 1 commit into
mainfrom
fix/docs-sidebar-padding

Conversation

@SirDarcanos

Copy link
Copy Markdown
Contributor

Summary

Keeps sidebar labels 10px away from their left borders, including hover and focus states. The upstream documentation template was overriding the intended padding with 0px normally and 5px on hover.

A narrowly scoped CSS override fixes the cascade without changing typography, active styling or nested indentation. The layout check now rejects collapsed sidebar padding; tooling instructions and the Unreleased changelog are updated.

Verification

Guide and API pages passed six mobile/desktop/wide layout checks and 36 normal/hover/focus measurements. Screenshots confirm spacing for nested and current-page items. Removing the override reproduces the reset and fails the regression guard. Both independent reviews found no issues.

Documentation build, links and snippets passed. Merging triggers the existing Spacefast documentation workflow; no library release is involved.

Validation details
  • Base c4579a396fc66923ef49d72f79d7b8abfb2b44d4; commit cd6202be5ae314936032378f0843364d2f2bfb7f. All 12 reviewed source/support content/mode/absence fingerprints are preserved after commit, with a clean worktree.
  • php tools/docs/build.php and generated-page checks passed for 1,606 HTML pages; example checks passed 35 PHP fragments with synthetic tutorial/migration reads; 495 repository Markdown links passed. Generated-page/snippet/link checks and diff hygiene were renewed after the content-identical commit.
  • Isolated installed Chrome/CDP checked Upload guide and Client API pages at 390, 1280 and 1920px. Header/body/footer geometry, mobile menu visibility and overflow checks passed. Two link levels × three states × six page/viewports yielded 36 measurements, all 10px. Hover used forced CSS pseudo-state; focus used actual element focus. Screenshots were inspected.
  • Negative browser fixture removes only the scoped padding rule and is rejected by the computed-padding guard. The first harness attempt retained a transitional computed value; disabling transitions for the negative fixture made it deterministic. No production fix or assertion was weakened.
  • Independent read-only Standards and Spec reviews inspected the frozen diff, upstream rules, screenshot and raw logs. Both found no issues. No repair cycles were needed after acceptance review.
  • JavaScript syntax and git diff --check passed. Zero PHPUnit tests or runtime-library files changed; no full-library suite rerun is claimed.
  • CI jobs/triggers and dependencies are unchanged. Documentation-only correction: no release-impact label, version bump, package publication, migrations or Wistia calls. Hosted compute impact is unmeasured. Source rollback is possible; rollback was not exercised.

@SirDarcanos
SirDarcanos merged commit b32f057 into main Oct 21, 2026
2 checks passed
@SirDarcanos
SirDarcanos deleted the fix/docs-sidebar-padding branch October 21, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant