[pranav256]

closed

[SunightMC]

hey! thank you so much for putting time into this, but i'm gonna have to vote upon closing this (leaving that decision up to someone like @Sammy99jsp). i went through the diff and built both this branch and dev locally to compare them. there's too much here that's broken, made up, or unrelated to merge it. specifically:

things that are explicitly broken:

• _document.tsx has a literal `n left in it (looks like a powershell newline escape), so "`n" shows up as text in the top-left corner of every page
• bootstrap's JS is removed, but the navbar toggler still relies on data-bs-toggle="collapse". so on phones the hamburger does nothing and there's no way to navigate. removing jquery on its own would've been fine, nothing uses it
• dynamic-width.ts now depends on [callback], but every caller passes an inline arrow function, so the listener gets removed and re-added on every render. combined with the new WidthRequirement, tapping "Continue anyway" on /demo on a phone doesn't close the popup. it just opens again right away
• turning MenuBar into a function makes the desktop navbar show two "Features" tabs
• the footer link styles are in scoped <style jsx>, which doesn't reach the <a> that next/link renders, so all the footer links are default blue now
• the description says marketing hype was replaced with verifiable descriptions, but a lot of the new feature copy says things we never claimed: layouts "optimized for ultra-wide and laptop displays" (the original says presets are based on your apps), "spatial breadcrumbs, instant indexing", and day & night syncing "with your ambient environment"

inaccurate stuff:

• the "still in development" banner and the "Under development" section on the features page are gone, while "Download ISO" buttons got added
• the "knowledge base articles" on support-beta are six cards that link to existing pages (one just goes to /), and the search box still doesn't do anything
• the manual is four cards linking to other pages. the "comprehensive shortcut map" card goes to /demo, and there's no shortcut map anywhere
• the docs page doesn't link to docs.avdanos.org anymore, and the torrent option on downloads is gone

completely unrelated changes (why??):

• the discord link was changed from avdanos.org/discord to discord.gg/avdanos with no explanation. we use our own domain on purpose so the invite can be changed in one place, to make it easier to find, and because we do not have a vanity URL
• instagram, mastodon and EULA are removed from the footer
• version bumped to 0.4.0
• a new "Design Standards" section in CONTRIBUTING.md that sets rules for the whole project
• window.window.localStorage?.getItem in TranslationList

honestly, the whole thing reads like it was generated and never actually opened in a browser. some of it is fair though: cleaning up the resize listener, getting rid of the class component inside Menu and closing the broken .header-dark-tabs rule are all real fixes. if you want to send those as small separate PRs (tested on mobile, with the translations left alone), we're happy to look at them. if you want to propose a redesign, please open an issue, or ping us on discord first so we can agree on a direction before every page gets rewritten.

[Sammy99jsp]

Hello! First, I'd also like to thank you for taking the time to look at this project and contribute!

I can't merge this PR as-is for many of the reasons that Sunight has already listed (btw thanks, @SunightMC). There are far too many things happening in this PR, which makes reviewing this quite difficult.

Design decisions in this project go through discussion either here on GitHub, or more frequently on our Discord. This goes for both code, design guidelines, and documentation. So if you think something should be changed, open an issue or discussion here, or join us for a chat on Discord.

For next steps, I think you should clearly separate this PR into around 3-5 smaller ones. Focus on things that maintain the existing codebase instead of changing any copywriting, design, or translation work. Here are some ideas:

• Update/Replace/Remove Deps: this codebase is quite old, so this should involve some form of testing to ensure everything still works after major/breaking version upgrades.
• Group all your Accessibility (a11y) & SEO fixes into one PR.
• Group any minor style fixes in another PR. Again, no new radical features or design without discussing with us first, please.
• Other small fixes not listed above can be grouped into another PR. One commit should apply the same fix across all pages/components.

Also, whilst using AI is not explicitly banned within this project, you do need to be able to read, understand, maintain, and defend your own code when someone else reviews it. Sunight has already pointed out quite a few things regarding this.

I will therefore be closing this PR as this is not feasible to review in its current state.

[geeky-lynx]

bro just renamed his pr to "closed" 💀