launcher: pass badgeLabel through for external plugin items - #3152
Draft
wbartcollins wants to merge 1 commit into
Draft
launcher: pass badgeLabel through for external plugin items#3152wbartcollins wants to merge 1 commit into
wbartcollins wants to merge 1 commit into
Conversation
SpotlightResultRow and ResultItem both check item.badgeLabel before falling back to the generic "Plugin" type label, and transformBuiltInLauncherItem already forwards it — but transformPluginItem never copied the field, so external launcher plugins could not customize their badge. Forward it the same way the built-in transformer does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both launcher row widgets (
SpotlightResultRowandResultItem) checkitem.badgeLabelbefore falling back to the generic "Plugin" type chip, andtransformBuiltInLauncherItemalready forwards the field — buttransformPluginItemnever copied it, so items returned by external launcher plugins can't customize their badge and always show "Plugin".This forwards
badgeLabelfor external plugin items the same way the built-in transformer does. Behavior is unchanged for plugins that don't set it (empty string falls through to the existing type-label switch).Use case: a plugin listing projects across several machines can put the machine name in the badge instead of the redundant "Plugin" label.