Skip to content

chore(deps-dev): update oxlint and oxfmt and fix new lint findings - #38

Closed
batonac wants to merge 2 commits into
developfrom
chore/toolchain-oxlint-1-89
Closed

batonac wants to merge 2 commits into
developfrom
chore/toolchain-oxlint-1-89

Conversation

@batonac

@batonac batonac commented Oct 23, 2026

Copy link
Copy Markdown
Member

Supersedes #37 (Dependabot closes it once this bump lands).

  • Bumps oxfmt to ^0.74.0 and oxlint to ^1.89.0. package.json and yarn.lock match Dependabot's versions.
  • oxlint 1.89 reports nothing new.
  • oxfmt 0.74 now reads the tab width from .editorconfig indent_size (4) when the oxfmt config doesn't set one (oxc#27778). A few lines therefore go over printWidth 110 and get re-wrapped. This PR commits the formatter output from prek run --all-files for font_select.ts, esign_webform_script.ts and marketplace/screenshots.ts. There are no code changes.

Note: the longer-term fix is to pin tabWidth in frappe-nix's managed .oxfmtrc.jsonc. If that ships with width 2, the next sync may wrap these lines back.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SvdEeMiewirZ3ifFoUix5F

batonac and others added 2 commits October 23, 2026 11:53
oxfmt 0.74 takes the tab width from .editorconfig indent_size (4) when
the oxfmt config does not set one, so three lines now exceed printWidth
and are re-wrapped. Formatter output only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SvdEeMiewirZ3ifFoUix5F
@batonac

batonac commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

Closing: the oxfmt 0.74 failure is fixed centrally in frappe-nix (Avunu/frappe-nix#187 pins tabWidth 2, matching how this code is already formatted). After the next frappe-nix release and sync, Dependabot's toolchain PR passes with no reformat.

@batonac batonac closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant