Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions sentinelml/drift/sanitizer.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from numbers import Real

import numpy as np
from typing import Tuple

Expand All @@ -21,5 +23,15 @@ def sanitize_arrays(baseline: np.ndarray, current: np.ndarray) -> Tuple[np.ndarr

@staticmethod
def is_constant_feature(data: np.ndarray, tolerance: float = 1e-8) -> bool:
"""Flags degenerate zero-variance features to prevent division by zero in bucket calculations."""
return bool(np.std(data) < tolerance)
"""Flag low-variance finite samples using an absolute standard-deviation tolerance."""
if (isinstance(tolerance, bool) or not isinstance(tolerance, Real)
or not np.isfinite(tolerance) or tolerance < 0):
raise ValueError("tolerance must be a finite nonnegative number")
clean, _ = DataSanitizer.sanitize_arrays(data, data)
scale = np.max(np.abs(clean))
if scale == 0:
return tolerance > 0
normalized_std = np.std(clean / scale)
if normalized_std == 0:
return tolerance > 0
return bool(normalized_std * scale < tolerance)
23 changes: 23 additions & 0 deletions tests/test_constant_feature_sanitizer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import numpy as np
import pytest

from sentinelml.drift.sanitizer import DataSanitizer


def test_constant_feature_handles_extreme_finite_values():
with np.errstate(over="raise", invalid="raise"):
assert DataSanitizer.is_constant_feature([1e308, 1e308])
assert DataSanitizer.is_constant_feature([-1e308, 1e308], tolerance=1.1e308)
assert not DataSanitizer.is_constant_feature([-1e308, 1e308], tolerance=0.9e308)


def test_constant_feature_ignores_nonfinite_values_but_requires_finite_sample():
assert DataSanitizer.is_constant_feature([np.nan, 7., np.inf, 7.])
with pytest.raises(ValueError, match="finite samples"):
DataSanitizer.is_constant_feature([np.nan, np.inf])


@pytest.mark.parametrize("tolerance", [True, -1., np.nan, np.inf, "bad"])
def test_constant_feature_rejects_invalid_tolerance(tolerance):
with pytest.raises(ValueError, match="tolerance"):
DataSanitizer.is_constant_feature([1., 1.], tolerance=tolerance)
Loading