Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opposite extreme finite values can overflow histogram-bin construction and report zero drift for completely different constant samples. Scale extreme finite inputs before computing quantile and fallback bins in both the public PSI helper and pipeline implementation; a positive common scale preserves bucket comparisons.
Validation: four extreme-value checks (including equivalent rescaled inputs) and existing drift tests: 50 passed. The original public and pipeline implementations each fail their opposite-constant regression. Scoped Ruff E/F (excluding existing line-length violations) and git diff --check passed. The tested changed files match the base version of current main. Full suite not run. AI-assisted contribution.