Bump typespec-java pinned http-client-java core commit - #5356
Open
iscai-msft wants to merge 1 commit into
Open
Conversation
Update core-commit.json to a newer core (microsoft/typespec) commit that includes the fix for Javadoc corruption from literal */ in parameter descriptions (microsoft/typespec#11766), which was causing Java compile failures in the Regen & Spector Tests CI job. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b371c61c-78d6-403f-a7bd-7a607faf82b5
iscai-msft
enabled auto-merge
August 31, 2026 18:47
microsoft-github-policy-service
Bot
added
the
emitter:java
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
📦 Package size report✅ No notable package size changes compared to the base branch. 13 package(s) with no notable change
Packed = gzipped |
commit: |
Contributor
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/typespec-javapins thehttp-client-javasources it consumes from thecore(microsoft/typespec) submodule viacore-commit.json, independent of whatever commit the submodule itself is checked out to. This meant a fix landed incorewas not actually being picked up.Bumps
core-commit.json'sshafrom27b39b71bf5c67f560ec6035900ae5621226ac8dto0bd0c174228cf559ec7d4c9edec904294b59b9bc, which includes microsoft/typespec#11766 "Fix Javadoc corruption from literal*/in parameter description". That fix resolves theRegen & Spector TestsCI failure seen on #5305 (unrelated PR — the failure was a real compile error in generated Java, not flakiness).Verification
pnpm turbo run --filter "@azure-tools/typespec-java^..." buildpnpm run regenerate(inpackages/typespec-java) — all specs regenerate successfullymvn compile -f emitter-tests/pom.xml— generated Java compiles cleanly (previously failed with';' expected/<identifier> expectederrors inFileClient.java)pnpm run test:java:e2e— Spector e2e tests pass (BUILD SUCCESS)pnpm lintpasses