Skip to content

Fork Sync Branch 19.0 - #28

Merged
btl-bot merged 7 commits into
BTLzdravtech:19.0from
ingadhoc:19.0
Nov 5, 2026
Merged

btl-bot merged 7 commits into
BTLzdravtech:19.0from
ingadhoc:19.0

Conversation

@btl-bot

@btl-bot btl-bot commented Nov 5, 2026

Copy link
Copy Markdown

No description provided.

cav-adhoc and others added 7 commits October 29, 2026 13:00
self._context is deprecated since 19.0 and logs a DeprecationWarning,
which runbot takes as an error once the module has tests.

Part-of: #482
Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
Characterization tests before the migration to 20.0:
- the file is split in parts of the row limit, each part keeps the
  header rows (also with empty rows before the header in a csv),
  rows without date go to no part, one background job per part and
  each statement named 'Part i/n', with no line lost or repeated;
- without the row limit the import runs right away, with no job.

Each test was seen failing by breaking the code it checks.

closes #482

Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
…s nothing to split

The background import exists to split a big sheet in parts, which needs a
sheet mapping. Without mapping (an OFX, a CAMT, a sheet without mapping),
or with a sheet without dated rows, the whole file was enqueued as bytes,
and base_bg refused it as not JSON serializable: the import button raised
a technical error. It now imports right away, as Odoo does without this
module.

Without the row limit, the import ran right away but caught any error and
returned it as text, so the wizard closed showing nothing. Outside a
background job the error now reaches the wizard; it is only turned into a
message inside the job, where nobody is looking at the wizard.

closes #483

Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
…like row 1

The csv parser and the preview of the mapping read a header row set at
0 from the first row, as with 1. The xls and xlsx parsers read that row
as a transaction too, so a mapping that imports a csv failed on the
same file as a spreadsheet, and the preview had to warn about it.

Both spreadsheet readers now start the transactions after the header,
like the csv parser, and the warning and its error hint go away.

Part-of: #486
Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
…and fail the job on error

With the header row at 0 the split put no header in the parts: the
header landed in the first part as a transaction and the other parts
had none. The parts now carry the first row as their header, which is
where the parsers read it from.

The job also caught any error and returned it as the message for the
user, so base_bg marked the job done without a statement. The error now
propagates and the job ends failed, with the error on the job.

closes #486

Signed-off-by: rov-adhoc <rov@adhoc.com.ar>
Updated by "Update PO files to match POT (msgmerge)" add-on in Weblate.

Translation: miscellaneous-19.0/miscellaneous-19.0-account_statement_import_sheet_file_ux
Translate-URL: https://translation.dev-adhoc.com/projects/miscellaneous-19-0/miscellaneous-19-0-account_statement_import_sheet_file_ux/

@sireko sireko left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved

@btl-bot
btl-bot merged commit 5171a75 into BTLzdravtech:19.0 Nov 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants