Repository navigation
Fork Sync Branch 18.0 - #239
Merged
Merged
Conversation
Maximizing a dialog, by default or with the maximize/restore button, dispatched a synthetic window resize event. Components that close on window resize then close as well, even when they own the dialog. For example, in the analytic distribution widget, choosing "Search More..." on an analytic account opens the dialog, the resize closes the widget popup and the dialog is destroyed with it, so it disappears immediately (or as soon as it is maximized or restored by hand). The resize was there to make a list with manually resized columns fill the new dialog size: manual resizing fixes the width of the table and its parent in pixels, so the list no longer follows the dialog width. Unset those widths instead when using the buttons, so the list fits its columns through its own resize observer. Maximizing on open needs nothing, as no column has been resized yet.
The button only showed the icon matching the dialog size it had when it was first rendered. Its props (the size getter and setter) never change, so rendering the dialog with a new size does not render the button again. With "default maximize" on, the dialog opened maximized with the maximize icon, and clicking it did nothing, so it could not be restored. Keep the size in the button state so it switches icon on each change.
Backport of the 20.0 module (#3680). Replace the solid purple navbar of the backend by a light one, by overriding the navbar variables of web. In 18.0 the menu entries take the full height of the navbar, so the bottom line is drawn in a pseudo-element on top of them instead of the border of web. It only applies to the bright color scheme, so dark mode is left to web_dark_mode. Assisted-by: Claude Opus 5.5
sireko
approved these changes
Nov 12, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.