fix(tui): silence trim signals and tool execution times - #52
Merged
Conversation
Engine housekeeping is not user-actionable and no longer surfaces: agent_signal/trim never reaches the notice strip (other subtypes keep flowing), and the per-step execution time is dropped from the compact tool-step right rail, which now carries only the typed chip (diffstat / test verdict). Durations are still recorded on the step struct. Doc sync: README engine-notices bullet, INTEGRATIONS event table, REDESIGN step-line spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What\n\n- Trim signals silenced —
agent_signalwith subtypetrimno longer reaches the notice strip (internal/tui/events.go). Other subtypes keep flowing; the case is the extension point for any future actionable signal.\n- Tool execution times silenced — the compact tool-step right rail no longer renders the per-call duration (internal/tui/view.go). The rail now carries only the typed chip (diffstat / ✓ tests pass). Durations stay recorded on the step struct for future surfaces (/stats, drawer).\n\nUntouched by scope: memory merges, skill loads, sub-agent telemetry (incl. card durations), all command feedback.\n\n## Why\n\nOnly transient messages the user can act on belong in the output; trim notices and per-tool execution times are engine housekeeping — internal noise, not actionable content.\n\n## Tests\n\nTDD, RED-first:\n-TestTrimSignalSilenced— trim posts no notice; non-trim subtypes still do\n-TestStepDuration— flipped: a done step head must NOT render a duration (recording still asserted)\n\nGates:make fmt✓ ·make vet✓ ·make lint0 issues ✓ ·make test(race) all packages ✓