feat(tui): typed step chips for tests, git, lint, warnings, http, hits - #54
Merged
Conversation
Step lines earn at most one typed chip, matched from structured output
only and gated on the command words where prose could leak in:
- test verdicts with counts, skips, and go coverage (go test, pytest,
jest, vitest, cargo, TAP) — loose substring matching ("ok ", " passed",
"testsuite") is gone, prose never goes green, and failing cargo runs
no longer render as passing
- git commits (⎇ hash + subject) and pushes (↑ branch)
- linter results (✓ lint clean / N issues)
- compiler warning summaries (⚠ N warnings, amber)
- HTTP statuses for curl/wget/httpie (● code, green/amber/red)
- search hit counts on grep/glob/search steps
SGR color residue is stripped before matching, counted verdicts fire
only on summary-shaped lines, and doubled runner summaries dedupe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step lines earn at most one typed chip, matched from structured output only:
\nok," passed",testsuite) that green-lit prose like "Build passed" and even misreported failing cargo runs as green⎇ a1b2c3d fix: subjectfor commits,↑ main/↑ up to datefor pushes (arg-gated)✓ lint clean/ redN issuesincl. golangci-lint's colon form (word-gated)⚠ N warningsfrom compiler summary lines only● 200green/amber/red for curl/wget/httpie (client-gated, final status wins)N hitson grep/glob/search steps onlyHardening (2-judge review): SGR color residue stripped before matching, counted verdicts fire only on summary-shaped lines (incl. default pytest
====padding), doubled runner summaries dedupe, cargo per-package repeats preserved.Review
2 expert judges ran on this diff; all MUST-FIX findings (ANSI residue, prose verdicts, default-pytest summary shape) are fixed with fixture rows.
Test plan
make fmt/make vet/make lint— 0 issuesmake test— full race suite greenrenderers_test.gocovers every chip family incl. colored output, prose noise, and gating negatives