fix(tui): silence tool_running agent_signal heartbeats - #55
Merged
Conversation
tool_running signals are engine housekeeping duplicating the in-flight step spinner — extend the trim-silencing contract to cover them. All other agent_signal subtypes still surface as notices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extends the
agent_signalsilencing contract (#52) to covertool_runningheartbeats.Why
Every
tool_runningsignal surfaced as a transient notice (signal · tool_running …), duplicating what the in-flight step spinner already shows in the transcript. Pure noise during tool-heavy turns.How
internal/tui/events.go—tool_runningjoinstrimas silent housekeeping; all other subtypes still flow to the notice stripinternal/tui/notices_test.go—TestTrimSignalSilencedextended RED-first to pin the new contractVerification
make vet/make lint: 0 issuesgo test -race -count=1 ./...: all packages green