Repository navigation
Remove references to dropped platforms and AMD archs from tests - #2
Merged
Merged
Conversation
The trim removed Windows, s390x and SVE256 support and AMD hardware below gfx1150, but tests and torch.testing helpers still referenced IS_WINDOWS, IS_S390X, IS_CPU_CAPABILITY_SVE256, MI200_ARCH, MI300_ARCH and NAVI3_ARCH. common_methods_invocations imported MI200_ARCH, so every test importing it (test_cuda.py among them) failed at collection. Delete IS_WINDOWS from common_utils and fold these always-false flags out of conditions, conditional expressions, `if` blocks and skip/xfail decorators, dropping the imports and the skips that can no longer fire. ck_tile grouped-gemm checks keep only gfx950. ruff reports no new F821 or F401 in the touched files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cyyever
force-pushed
the
drop-dead-platform-flags
branch
from
October 23, 2026 00:44
9ddac87 to
4f97cce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common_methods_invocationsimportedMI200_ARCH, which the trim removed, so every test that imports it failed at collection;test_cuda.pywas one of them.IS_WINDOWSfromcommon_utils. Fold the always-false flagsIS_WINDOWS,IS_S390XandIS_CPU_CAPABILITY_SVE256out of conditions, conditional expressions,ifblocks and skip/xfail decorators, using a libcst pass that only touches names imported fromtorch.testing._internal. LocalIS_WINDOWSdefinitions andtorch.utils.cpp_extension.IS_WINDOWSare left alone.MI200_ARCH/MI300_ARCH/NAVI3_ARCHskips, tolerances and imports. The ck_tile grouped-gemm checks keep onlyMI350_ARCH.Test plan
trim, ruff reports no new F821 or F401 in them.pytest --collect-only test_cuda.pycollects 846 tests (before: ImportError).🤖 Generated with Claude Code