Repository navigation
Add shared cuFile/hipFile weight destinations - #1
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com> Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Co-authored-by: OpenAI Codex <noreply@openai.com> Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Foundation for reading weights into existing device tensors through the shared cuFile/hipFile loader. Avoid a full CPU assembly buffer when a caller supplies a compatible contiguous destination.
Claims
Validation
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --no-project .venv/bin/python -m pytest --confcutdir=tests/model_executor/model_loader -o addopts= tests/model_executor/model_loader/test_direct_io.py tests/model_executor/model_loader/test_hipfile.py -q.git diff --checkpassed.Details
The current compatibility loader assembles oversized tensors on CPU using bounded device reads. A destination resolver avoids that staging when the final device tensor is available. Writes synchronize before and after the external reader; noncontiguous, CPU, or dtype-converting sharded destinations retain the old path.
This does not require converting downloaded checkpoints, but the first caller is the existing sharded-state loader. It DOES NOT yet accelerate the original HF Qwen checkpoint. Ordinary HF weight mapping, fused/reshaped weights, native safetensors buffer/DLPack integration, and hardware correctness/benchmarking remain outstanding. No model-specific layout or new checkpoint format is introduced.
Duplicate search: no open BakeLab/vllm PRs; upstream searches for cuFile destination and hipFile found no matching model-loader change (the cuFile result concerned KV offload). This is a BakeLab fork draft, not an upstream submission.
Remaining work
Pull Request Checklist
/pr-checklistskill.