Repository navigation
fix(crew): say when setup replaced Crew, and badge a channel's owner correctly - #409
Merged
Merged
Conversation
…s Channel owner
Setup in the desktop app read "Installed Crew 1.93.0." after replacing a
same-version copy with other bytes, though the daemon reported the
replacement (outcome.upgraded_from, previous_kept) and the CLI and the
manual both say which copy was replaced. setup.ts now keeps
previous_kept and a validated upgraded_from.version, and the install
step says "Replaced Crew {v} with this computer's copy of it." or
"Updated Crew from {a} to {b}.", as the CLI's setup_summary_lines does.
A fresh install and a reuse read as before.
Add people to a channel marked the channel's owner "Team owner": the
label tested whether a team had resolved, which is always true for a
channel. It now follows the dialog's target, so a channel's owner is
"Channel owner" as on the Members tab, and a team keeps "Team owner".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two Crew GUI defects found by the final regression run on main after #403-#407, each confirmed by an independent reproduction.
previous_keptand a version-checkedupgraded_from.version. The step reads "Updated Crew from {a} to {b}.", "Replaced Crew {v} with this computer's copy of it." or "Replaced the Crew program with Crew {v}.", chosen in the same order as the CLI'ssetup_summary_lines. A fresh install and a reuse read as before.ui/desktop/src/components/crew/onboarding/setup.ts,SetupProgress.tsx,copy.ts.docs/crew/hosting-a-workspace.mdlists the three sentences.AddPeopleDialog.tsx), as the Members tab already did. This one is pre-existing (also in v1.93.0).Every changed line serves one of these two fixes.
Test plan
setup.test.ts,SetupProgress.test.tsxandAddPeopleDialog.test.tsx. Each one fails with its fix undone.npm run lint:check,npm run format:check,node scripts/check-crew-manual.mjsandscripts/check-no-goose-block.shpass..previous.🤖 Generated with Claude Code