Skip to content

fix(release): give Windows smoke profiles a private ACL #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Broccolito merged 1 commit into from
Oct 25, 2026
Merged

fix(release): give Windows smoke profiles a private ACL #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions scripts/windows/installed-release-smoke.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,18 @@ function Stop-OwnedProcess {
}

try {
# A real profile folder is private to its account. RUNNER_TEMP inherits the
# drive root's "Users may create folders" entry, which private storage refuses.
New-Item -ItemType Directory -Path $root -Force | Out-Null
$rootAcl = [Security.AccessControl.DirectorySecurity]::new()
$rootAcl.SetAccessRuleProtection($true, $false)
foreach ($sid in @([Security.Principal.WindowsIdentity]::GetCurrent().User,
[Security.Principal.SecurityIdentifier]::new('S-1-5-18'),
[Security.Principal.SecurityIdentifier]::new('S-1-5-32-544'))) {
$rootAcl.AddAccessRule([Security.AccessControl.FileSystemAccessRule]::new($sid, 'FullControl',
'ContainerInherit,ObjectInherit', 'None', 'Allow'))
}
Set-Acl -LiteralPath $root -AclObject $rootAcl
New-Item -ItemType Directory -Path $local, (Join-Path $root 'roaming'), (Join-Path $root 'electron') -Force | Out-Null
$result.assets = @(Get-Content -LiteralPath $AssetEvidence -Raw | ConvertFrom-Json)
if ($result.assets.Count -ne 2) { throw 'Expected authenticated ZIP and Setup asset evidence' }
Expand Down
12 changes: 12 additions & 0 deletions scripts/windows/normal-release-smoke.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,18 @@ $expression = @'
'@

try {
# A real profile folder is private to its account. RUNNER_TEMP inherits the
# drive root's "Users may create folders" entry, which private storage refuses.
New-Item -ItemType Directory -Path $root -Force | Out-Null
$rootAcl = [Security.AccessControl.DirectorySecurity]::new()
$rootAcl.SetAccessRuleProtection($true, $false)
foreach ($sid in @([Security.Principal.WindowsIdentity]::GetCurrent().User,
[Security.Principal.SecurityIdentifier]::new('S-1-5-18'),
[Security.Principal.SecurityIdentifier]::new('S-1-5-32-544'))) {
$rootAcl.AddAccessRule([Security.AccessControl.FileSystemAccessRule]::new($sid, 'FullControl',
'ContainerInherit,ObjectInherit', 'None', 'Allow'))
}
Set-Acl -LiteralPath $root -AclObject $rootAcl
New-Item -ItemType Directory -Force -Path $normalUserDataDirectory, (Join-Path $root 'local'), (Join-Path $root 'roaming'),
(Join-Path $root 'home'), (Split-Path -Parent $Report) | Out-Null
$result.assets = @(Get-Content -LiteralPath $AssetEvidence -Raw | ConvertFrom-Json)
Expand Down
Loading