Skip to content

Fix queued proxy votes being rejected by vote delay#1532

Merged
BenCodez merged 3 commits into
masterfrom
agent/fix-proxy-queued-vote-delay
Jul 22, 2026
Merged

Fix queued proxy votes being rejected by vote delay#1532
BenCodez merged 3 commits into
masterfrom
agent/fix-proxy-queued-vote-delay

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Summary

  • allow a queued VotingPlugin proxy vote when its forwarded vote timestamp already matches the backend's stored LastVotes timestamp
  • retain WaitUntilVoteDelay enforcement for direct votes and stale proxy timestamps
  • add a focused regression test for the timestamp match

Root cause

The proxy writes the real vote time before a queued offline vote reaches the backend. The backend then reads that same value from LastVotes and incorrectly treats the queued delivery as a vote that is still on cooldown, skipping rewards and milestone evaluation.

Validation

  • Added ProxyVoteDelayCheckTest covering the accepted queued-proxy case and rejected direct/stale cases.
  • Maven is not installed in this environment, so the test suite could not be executed locally.

@BenCodez
BenCodez marked this pull request as ready for review July 22, 2026 22:15
@BenCodez
BenCodez merged commit 46f86f8 into master Jul 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant