fix: don't queue duplicate search conversations in value GUI - #452
Merged
Conversation
Bukkit queues conversations per player, so every click on the value panel's search button started another 90-second conversation. When the player finally typed in chat (or the timeouts expired), the queued conversations replayed one after another as alternating 'Conversation cancelled!' / 'Please enter a search value' spam, with the GUI re-opening each time. If the player is already conversing, repeat the pending question instead of beginning a new conversation. Fixes #451 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NSvRYW3Rgh6Vgvx62QRYE1
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #451.
Bukkit queues conversations per player, so every click on the value panel's search button began another 90-second conversation. If the first prompt wasn't visible (e.g. a chat-managing plugin like CMI swallowed it), players clicked the button repeatedly, stacking conversations that later replayed as alternating
Conversation cancelled!/Please enter a search valuespam with the GUI re-opening each time.Fix
ConversationUtils.createStringInputnow checksPlayer#isConversing()first. If a conversation is already pending, it closes the GUI and repeats the question (with the usual prefix) instead of queueing a second conversation — so the pending prompt still works and no spam accumulates.Testing
ConversationUtilsTest: verifies a conversation starts normally when none is pending, and that no second conversation is begun (question is re-sent instead) when one is already active.🤖 Generated with Claude Code
https://claude.ai/code/session_01NSvRYW3Rgh6Vgvx62QRYE1