feat(build): ship simdjson.h beside the ext/simdjson headers - #165
Conversation
The installed ext/simdjson bindings header includes "simdjson.h", which the build kit did not carry, so an extension including those headers could not compile with phpize. Stage the amalgamated header beside it, stop packaging when it is missing, and read the kit include folder through KIT_INCLUDE in stage_header_closure.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe packaging script now stages ChangesSimdjson header packaging
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The package now includes the sibling header required by the pinned simdjson extension. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the change and its recipe identity impact, but it does not use the required Summary, Verification, or Security and licensing sections. It also omits the required verification and licensing check items. Resolution Restructure the description with the template headings. Add the required Verification checklist, including scripts/test.sh, the macOS arm64 build stage, module diff review, and release-contract compatibility. Add the Security and licensing checklist, including credentials, generated artifacts, licenses, and immutable pins. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
* origin/main: fix(autorelease): email publish runs, set Latest, and resume finalize (#164)
The installed
ext/simdjsonbindings header includes"simdjson.h", which the build kit didn't ship, so an extension using those headers couldn't compile withphpize. Packaging now stages the amalgamated header beside it and stops when it's missing. It also reads the kit include folder throughKIT_INCLUDEinstage_header_closure.scripts/package.shis a recipe input, so this changes the recipe identity. After merge the watcher rebuilds every maintained release once more, one per run:-3for 8.5.11, 8.5.10, 8.5.9, 8.5.8, 8.4.23, 8.3.32 and 8.2.32, and-2for 8.4.26, 8.3.35 and 8.2.34.Summary by CodeRabbit
ext/simdjsonusingphpizealone.simdjson.halongside the PHP bindings header.