Repository navigation
bug: Calculate rel_increase_comp independently of plotting #136
Description
Describe the bug
rel_increase_comp is calculated only when plots are made. This seems illogical/unintuitive, because why would the calculation of a metric depend on whether a plot is made.
To Reproduce
Run sb with make_plots=False
Expected behavior
rel_increase_comp should be calculated?
Screenshots
n/a
Desktop (please complete the following information):
n/a
You have a solution? (optional)
Please always calculate rel_increase_comp
Additional context
We just noticed after a big batch export that this metric was not included.
PS there is no urgency to this, but probably something that could be fixed eventually.
Activity
cbueth commentedon Sep 16, 2026
Hey @mszell, thanks for raising. The
calculate_allwithmake_plots=Falsedoes compute the edge-wiserel_increasewithwrite_relative_increase_to_edges, but not the component-wise one. I think this number was motivated through plotting and initially not for such batch export withsave_to_gpkg.The needed code to make the conversion is in
plot_component_wise_travel_increaseitself, but should be moved over.I am working on this in
feat/calculate-rel-increase-comp-independentlyand will push it soon, then you could test it.cbueth commentedon Oct 1, 2026
If you test this again on #137 and it works, @mszell, we can merge that PR.