Repository navigation
Fix I801 resource lookup affecting memory temperature reads - #13
Open
chenx-dust wants to merge 1 commit into
Open
chenx-dust wants to merge 1 commit into
chenx-dust wants to merge 1 commit into
Conversation
Owner
|
Thank you for your PR. Note: the suggested change is for legacy support of an old unsafe driver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses a memory temperature reading issue on my current machine when using the WMI-based I801 SMBus detection path.
Inside the controller enumeration loop, the resource lookup uses pnpSignedDriver[0]["DeviceID"] instead of the current controller's DeviceID. If the current Intel controller is not the first WMI result, this can select an unrelated I/O range or unnecessarily fall back to the fixed address, affecting subsequent memory temperature reads.
Use item["DeviceID"] so the resource lookup matches the controller passed to TryAddSMBus.
Assisted by GPT 6 Astra