Skip to content

fix: remove HEAD toggle to restore Ctrl-G commit generation - #41

Merged
Blankeos merged 1 commit into
mainfrom
fix/ctrl-g-commit-generation
Oct 6, 2026
Merged

Blankeos merged 1 commit into
mainfrom
fix/ctrl-g-commit-generation

Conversation

@Blankeos

@Blankeos Blankeos commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Summary

Implements the maintainer's latest feedback on #34: #34 (comment)

  • Remove the Files/HEAD toggle and its universal config key, handlers, palette entries, and status hints. Ctrl-G no longer steals the existing Files AI commit-message generation action.
  • Preserve Ctrl-G in the commit editor, configurable Files generation shortcuts, normal 2/4 panel navigation, and the --commits startup flag with actual HEAD/filter-aware selection.
  • Legacy toggleWorkingTreeAndHead config entries remain harmless unknown fields; existing configurations still load.
  • Update README guidance and run just sync_readme (also brings the previously stale npm README into sync).

Validation

  • Confirmed the new Files Ctrl-G regression fails before the fix by switching to Commits.
  • Added staged/unstaged Files generation, commit-editor generation, remapped shortcut, no panel-toggle, legacy config, and status-hint regression coverage. Tests do not invoke an AI provider.
  • Retained startup HEAD/filter/detached/pagination regression coverage.
  • cargo fmt --check
  • cargo test β€” 315 passed, 1 manual benchmark ignored
  • cargo clippy --all-targets β€” completed with warnings

Developed in a separate worktree branched from origin/main.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review βœ… Completed 2026-10-06T18:18:16.931243Z 0e58f26 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@Blankeos
Blankeos merged commit 6271245 into main Oct 6, 2026
6 checks passed
Blankeos added a commit to felipecm-br/lazygitrs that referenced this pull request Oct 6, 2026
Bring PR Blankeos#35 up to date with Blankeos#41 without reintroducing the removed HEAD-toggle shortcut, footer hints, or configuration. Retain shell prompt binding and legacy-key regression coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant