Skip to content

Match the API more closely - #2

Merged
doersf merged 1 commit into
masterfrom
review-fixes
Oct 10, 2026
Merged

doersf merged 1 commit into
masterfrom
review-fixes

Conversation

@doersf

@doersf doersf commented Oct 10, 2026

Copy link
Copy Markdown
Member

Fixes from a review against the SoChain API, before the first release:

  • chart sends --currency only for price_usd; other series refuse it.
  • Orphaned blocks (confirmations -1) parse and say they're orphaned.
  • Inputs without an address are labelled by what they are: newly mined coins only for coinbase inputs, else the MWEB pool or "(no address)". Outputs into MWEB are labelled too.
  • Litecoin blocks leave the carried-over MWEB pool out of "moved".
  • price --time accepts unix seconds of 7 to 10 digits only, so milliseconds aren't silently answered with today's price.
  • balance --time before a network's first block says so instead of looking like today's balance.
  • Next-page hints keep --page-size and --currency.
  • Transaction ids and block hashes are sent in lower case.
  • A short 503 with Retry-After is waited out and retried.
  • fees suggests the next block's median rounded up to a whole unit.
  • rich-list --page is checked against the top 1,000.
  • balance-history labels each period and says balances are at its end.
  • Help and docs: keyless lookups are at least 2,500 a day; mcp install --use-api-key says where the key goes.

…cks, input labels, price times, paging hints
@doersf
doersf merged commit 7c879d6 into master Oct 10, 2026
14 checks passed
@doersf
doersf deleted the review-fixes branch October 10, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant