Add SIMPLICITY_FALLTHROUGH macro and enable -Wimplicit-fallthrough in CI#345
Open
delta1 wants to merge 1 commit into
Open
Add SIMPLICITY_FALLTHROUGH macro and enable -Wimplicit-fallthrough in CI#345delta1 wants to merge 1 commit into
delta1 wants to merge 1 commit into
Conversation
Replace the old /*@fallthrough@*/ comment convention with a [[fallthrough]]-style attribute macro so clang's -Wimplicit-fallthrough can verify intentional switch fallthroughs at compile time, and add a CI job that builds and tests the C library with clang under -Wimplicit-fallthrough -Wconditional-uninitialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old /@fallthrough@/ comment convention with a [[fallthrough]]-style attribute macro, so clang's -Wimplicit-fallthrough can verify intentional switch fallthroughs at compile time.
I noticed this from a failure in the newer Elements CI: https://github.com/ElementsProject/elements/actions/runs/28760714747/job/85394013375?pr=1569