Repository navigation
Adding SpyGlass as an alternative to prism and coreprotect - #451
Conversation
I had extra time on my hands.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="sidebars.js">
<violation number="1" location="sidebars.js:246">
P3: This PR rewrites the entire file from CRLF to LF line endings, so the diff shows 343 lines removed / 344 added for a one-line addition. That makes the change nearly impossible to review and risks merge conflicts with other open PRs touching sidebars.js. Preserve the original CRLF line endings and add only the spyglass entry.</violation>
</file>
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
| 'plugins_and_modifications/plugins/papi', // PlaceholderAPI | ||
| 'plugins_and_modifications/plugins/prism', | ||
| 'plugins_and_modifications/plugins/servernpc', | ||
| 'plugins_and_modifications/plugins/spyglass', |
There was a problem hiding this comment.
P3: This PR rewrites the entire file from CRLF to LF line endings, so the diff shows 343 lines removed / 344 added for a one-line addition. That makes the change nearly impossible to review and risks merge conflicts with other open PRs touching sidebars.js. Preserve the original CRLF line endings and add only the spyglass entry.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At sidebars.js, line 246:
<comment>This PR rewrites the entire file from CRLF to LF line endings, so the diff shows 343 lines removed / 344 added for a one-line addition. That makes the change nearly impossible to review and risks merge conflicts with other open PRs touching sidebars.js. Preserve the original CRLF line endings and add only the spyglass entry.</comment>
<file context>
@@ -1,343 +1,344 @@
+ 'plugins_and_modifications/plugins/papi', // PlaceholderAPI
+ 'plugins_and_modifications/plugins/prism',
+ 'plugins_and_modifications/plugins/servernpc',
+ 'plugins_and_modifications/plugins/spyglass',
+ 'plugins_and_modifications/plugins/tebex', // Minecraft server donation store integration, formerly known as BuyCraft
+ 'plugins_and_modifications/plugins/topper',
</file context>
There was a problem hiding this comment.
Hey @Swift-ality ! I have to agree with Cubic on this. I don't find the advantage of reformatting to be worth the "mess" it would make in our PR history, I would prefer keeping only the Spylgass entry. You can either commit a change to undo it or we can have Cubic resolve this.
JustAMatt
left a comment
JustAMatt
left a comment
There was a problem hiding this comment.
Please see my comment at #451 (comment)
Otherwise the guide is fine, if a bit short. Considering the plugin is still in active development I think this is a good start, we can expand the guide later on if needed.
Only the spyglass sidebar entry should change; the previous commit rewrote the whole file with LF endings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JustAMatt
left a comment
JustAMatt
left a comment
There was a problem hiding this comment.
Previous review was meant as a comment and not as an approval; Please see my comment at #451 (comment)
|
Hey @JustAMatt, I think GitHub did something, It was not my intention to change its format. |
JustAMatt
left a comment
JustAMatt
left a comment
There was a problem hiding this comment.
Sidebar.js was fixed to keep current formatting. The PR is approved.
|
@Swift-ality No worries! Thank you for the work! Merged |
I had extra time on my hands.