Repository navigation
[BI-2948] - Sample Submission Download - #551
Merged
Merged
Conversation
4 of 5 tasks
HMS17
marked this pull request as ready for review
September 9, 2026 15:59
HMS17
requested review from
a team and
nickpalladino
and removed request for
a team
September 9, 2026 17:05
nickpalladino
requested changes
Sep 11, 2026
| Map<String, Object> row = new HashMap<>(); | ||
| row.put(SampleSubmissionImport.Columns.GERMPLASM_NAME, sample.getAdditionalInfo().get(BrAPIAdditionalInfoFields.GERMPLASM_NAME).getAsString()); | ||
| row.put(SampleSubmissionImport.Columns.GERMPLASM_GID, sample.getAdditionalInfo().get(BrAPIAdditionalInfoFields.GID).getAsString()); | ||
| row.put(SampleSubmissionImport.Columns.OBS_UNIT_ID, sample.getObservationUnitDbId()); |
Member
There was a problem hiding this comment.
We should use the obsunitid stored in additionalinfo here because that's the deltabreed generated uuid and is what is shown on frontend and used for file import values currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2948 - Sample Submission Download
Added backend logic to allow export of sample submission columns for download
Moved sorting logic into helper method
Added unit test for sample submission export and added sorting tests to unit test for DArT file generation
Dependencies
bi-web: feature/BI-2948
Testing
see bi-web
Checklist: