Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-3048 - Exp Collaborator FB Endpoints: /germplasm
NOTE: ON HOLD
To enable experimental collaborators who are not system administrators to import fields in FieldBook, four endpoints must be made available to experimental collaborators while still limiting data to data related to experiments shared with the collaborator.
This card addresses the GET /germplasm endpoint, including making the endpoint accessible to experimental collaborators and retrieving no data when the user is an experimental collaborator. This is because the GET /germplasm endpoint is called when FieldBook loads a field, but it isn't necessary for loading a field and isn't data viewable to experimental collaborators on DeltaBreed anyway. It may be possible that in the future it could be swapped for a filter.
Dependencies
bi-web: develop
For FieldBook testing of importing fields as Experimental Collaborator, need BI-3049, BI-3050, and BI-3051 implemented
Testing
Only endpoint can be tested until BI-3049, BI-3050, and BI-3051 implemented
Experimental collaborators should be able to call GET /germplasm, but not retrieve any data
Note that when all cards implemented there will be a slight change in DeltaBreed behavior as well as enable FieldBook loading of data for experimental collaborators. Namely previously an experimental collaborator who is also a system administrator could view all germplasm in a program, whereas after this change no germplasm would display. (todo could maybe change this, but also discussion to be had re trials/experiments which also filters)
Checklist: