Repository navigation
[BI-3082] Implement sorting/filtering/pagination on germplasm list items - #567
Conversation
| li.getItem().putAdditionalInfoItem(BrAPIAdditionalInfoFields.GERMPLASM_LIST_ID, biGermplasmListId); | ||
| // listItem.position start of index is 0 in BrAPI, but in DeltaBreed, it starts at 1. increment result data to account for this. | ||
| // The actual sort/filter performs the search on a formula column created on the prod server, so no need to worry about that in the request above. | ||
| li.getItem().putAdditionalInfoItem(BrAPIAdditionalInfoFields.GERMPLASM_IMPORT_ENTRY_NUMBER, li.getListItem().getPosition() + 1); |
There was a problem hiding this comment.
The entry number shown here is position + 1, but sort and filter on importEntryNumber still go to the ProdServer as importEntryNumber (GermplasmQuery lines 77 and 96). On the server, that’s the germplasm’s own additionalInfo.importEntryNumber, not listItemPosition.
bi-web’s GermplasmTable sorts by importEntryNumber by default, so the server’s position-based default sort is never used. For any list whose positions differ from the germplasm’s original import entry numbers (for example, germplasm reused from an earlier import), rows come back out of list order, and filtering by entry number matches the wrong rows.
For list searches, can we map importEntryNumber to listItemPosition?
There was a problem hiding this comment.
importEntryNumber was switched to listItemPosition and the default was changed in bi-web in feature/BI-3089.
Description
Story: BI-3082
Dependencies
Testing
Test sorting/filtering/pagination of the Germplasm List Details page.
This is the page once you click on
Show Detailson a germplasm list from the Lists tab.Checklist: