Repository navigation
[BI-2923] Associate observation variables with brapi program db id on creation - #571
Open
jloux-brapi wants to merge 1 commit into
Open
jloux-brapi wants to merge 1 commit into
jloux-brapi wants to merge 1 commit into
Conversation
humsika
reviewed
Oct 28, 2026
| // Get brapi variables | ||
| VariableQueryParams variablesRequest = new VariableQueryParams(); | ||
| variablesRequest.externalReferenceSource(referenceSource); | ||
| variablesRequest.programDbId(brapiProgramDbId); |
Contributor
There was a problem hiding this comment.
since traits are now fetched only by programDbId, any variable with a NULL program_id will trigger the throw at line 211 for the whole program. The only way I can see that happening is if the ProdServer migration runs first and the old bi-api creates a trait before this version is deployed. Will these three PRs always be deployed together? If not, it might be worth falling back to the exref lookup for any trait IDs missing from the result.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2923
Dependencies
Testing
Ontology PageShow Detailsand then clickingEdit, where if they are not already used you can edit some elements of the term. Activating and Deactivating also updates ontology. Simplify verify the changes are reflected once they are made.Checklist: