Repository navigation
BI-2929: Fix issues with requesting later pages with larger pages sizes - #502
Merged
Merged
Conversation
jloux-brapi
approved these changes
Oct 23, 2026
jloux-brapi
left a comment
Contributor
There was a problem hiding this comment.
Approved, I do think it would be a good idea to have Nick look at this too just as a sanity check.
humsika
requested review from
nickpalladino
and removed request for
nickpalladino
October 23, 2026 16:44
nickpalladino
approved these changes
Oct 23, 2026
nickpalladino
left a comment
Member
There was a problem hiding this comment.
I checked all active tables to make sure they were using the paginationController. Only one that wasn't was the one in GermplasmGenotypeView and that's a bi-api based one that we don't show anymore in develop so not an issue. Shawn and I are good with the change in behavior when a page size is changed vs what it was before.
| * limitations under the License. | ||
| */ | ||
|
|
||
| import {PaginationController} from "@/breeding-insight/model/view_models/PaginationController"; |
Member
There was a problem hiding this comment.
We haven't typically been adding frontend tests but fine to add
Contributor
Author
There was a problem hiding this comment.
Thanks for confirming! I added the test to cover the pagination reset and prevent regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2929
When a user changes the page size while viewing a later page, that page might not exist with the new page size. This change resets the table to the first page whenever the page size changes, preventing an invalid page request.
Dependencies
bi-web: bug/BI-2929
bi-api: epic/BI-2862
brapi-Java-prodServer: epic/BI-2862
Testing
10 per page.10to200.1.page=0&pageSize=200.Checklist: