Skip to content

BI-3093: Disable Abort button on import confirm screen after user clicks Confirm. - #503

Merged
nickpalladino merged 1 commit into
developfrom
bug/BI-3093
Oct 27, 2026
Merged

nickpalladino merged 1 commit into
developfrom
bug/BI-3093

Conversation

@humsika

@humsika humsika commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

Story: BI-3093

The Abort button on the import confirm screen stayed enabled after the user clicked Confirm, so clicking it showed "Import cancelled" even though the import kept running in the background and the records were still created. This change disables the Abort button once Confirm is clicked, using the same condition as the Confirm button in the shared ConfirmImportMessageBox.vue, so the fix applies to the Experiments & Observations, Germplasm, Genotype Samples and Ontology imports with no backend changes.

Dependencies

bi-web: bug/BI-3093
bi-api: develop

Testing

For each import tab — Experiments & Observations, Germplasm, Genotype Samples and Ontology:

  1. Upload a valid file. On the "Importing..." screen, Abort should be enabled.
  2. On the preview/confirm screen, Abort should be enabled. Click Abort → "Yes, abort": "Import cancelled" is shown and no records are created.
  3. Upload again and click Confirm. Abort should be greyed out immediately and not clickable while the import is processing.
  4. After the success message, check the Jobs page (import Finished) and confirm only one set of records was created.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth
  • I have run SiteImprove on pages impacted by changes

@github-actions github-actions Bot added the bug Something isn't working label Oct 26, 2026
@humsika
humsika requested a review from nickpalladino October 26, 2026 21:34

@nickpalladino nickpalladino left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I also think it's ok leaving the state machine abort stuff as-is in case we ever want to revisit this.

@humsika

humsika commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! Sounds good, kept it as-is in case we revisit it later.

@nickpalladino
nickpalladino merged commit 39ee488 into develop Oct 27, 2026
2 checks passed
@nickpalladino
nickpalladino deleted the bug/BI-3093 branch October 27, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants