Repository navigation
BI-3093: Disable Abort button on import confirm screen after user clicks Confirm. - #503
Merged
Merged
Conversation
nickpalladino
approved these changes
Oct 27, 2026
nickpalladino
left a comment
Member
There was a problem hiding this comment.
Looks good, I also think it's ok leaving the state machine abort stuff as-is in case we ever want to revisit this.
Contributor
Author
|
Thanks! Sounds good, kept it as-is in case we revisit it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-3093
The Abort button on the import confirm screen stayed enabled after the user clicked Confirm, so clicking it showed "Import cancelled" even though the import kept running in the background and the records were still created. This change disables the Abort button once Confirm is clicked, using the same condition as the Confirm button in the shared
ConfirmImportMessageBox.vue, so the fix applies to the Experiments & Observations, Germplasm, Genotype Samples and Ontology imports with no backend changes.Dependencies
bi-web: bug/BI-3093
bi-api: develop
Testing
For each import tab — Experiments & Observations, Germplasm, Genotype Samples and Ontology:
Checklist: