Repository navigation
API-2971: OutOfMemoryError: java heap space assetService.uploadFile - #158
Merged
Merged
Conversation
|
coverage: 40.09% (+0.3%) from 39.819% — API-2971 into master |
- Thread HttpConnectionSettings through the Amazon S3 upload client (ApiFactory, AmazonS3Service/Impl, FileUploader, AssetService/Impl, BynderClientImpl) so upload timeouts are configurable instead of silently defaulting to OkHttp's hardcoded 10s connect/read/write timeouts, which caused SocketTimeoutException on large file uploads. - Fix RXUtils.mapWithIndex to pair chunks with their index via a lazy map instead of zipWith(Observable.range(...)), which greedily drained the entire file into memory before any chunk was uploaded, causing an OutOfMemoryError on multi-gigabyte files. - Switch FileUploader's chunk upload from flatMapSingle to concatMapSingle to process chunks strictly one at a time. - Update HttpConnectionSettingsTest to match the new default timeout. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ahongbynder
force-pushed
the
API-2971
branch
from
September 22, 2026 22:05
03ea798 to
f9550e9
Compare
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ahongbynder
marked this pull request as ready for review
September 23, 2026 22:05
thegreatdeku
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #157
Fixes SocketTimeoutException and OutOfMemoryError on large file uploads: