Conversation
When a symlink target under the watched dir changes, after_loop() restarts the observer. If Observer.start() fails (e.g. the inotify watch limit is reached or the target disappears mid-deploy), watchdog raises before the observer thread is started. The next loop sees the still stale symlink snapshot and tries to restart again, but joining the never-started thread raises "cannot join thread before it is started". start_observer() is never reached again, the tree is marked dirty and nginx is reloaded on every loop, forever, while nothing is being watched. Only join the observer when its thread is alive, so a failed start can be retried on the next loop and the reloader heals itself. Also only mark the tree dirty once the restart succeeded, so a failing restart no longer reloads nginx on every iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On server
nmsbva-****-magweb-tbbm, thenginx_config_reloadergets stuck in a loop after an observer fails to start correctly.On every check, it tries to restart the observer again, but
stop_observer()attempts to join a thread that was never started. This results in the following error roughly every 5 seconds:RuntimeError: cannot join thread before it is startedDespite the error,
Applying new configis still triggered, causing Nginx to be reloaded continuously.This matches the known issue in the symlink rearm logic where a single failed observer start can lead to an endless Nginx reload loop.