feat: add standalone recovery console and shared Harness settings - #432
Merged
Merged
Conversation
Replace the settings dialog with a non-modal surface beside the native rail. Keep navigation, selection, and settings requests functional on pages without a Composer. Inspired by https://github.com/liki-0814/codex-host/tree/feat/account-model-skill; the page integration is independently implemented. Co-authored-by: liki-0814 <182258439+liki-0814@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: BytePioneer-AI/codex-host/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (121)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b166a41b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+133
to
+135
| return installation.launcherExecutable | ||
| ? { command: installation.launcherExecutable, args: [] } | ||
| : null; |
There was a problem hiding this comment.
When the user clicks Start in the already-open recovery console for a macOS or Windows installer, this empty argument list invokes the Launcher's no-argument path. main.rs classifies that as Presentation::Browser, and console.rs immediately calls show(None), opening a second console tab; a startup failure can open yet another tab. Invoke the explicit launch command, as the npm wrapper does, or otherwise suppress console presentation for launches initiated by the console.
Useful? React with 👍 / 👎.
YanYunCY
added a commit
to YanYunCY/codex-host
that referenced
this pull request
Sep 28, 2026
Resolve the launcher test conflict and integrate the standalone Console from PR BytePioneer-AI#432 with the update handoff. Keep Windows installer updates available; require manual Windows npm and offline Windows/macOS Console updates until a cross-process Launcher handoff is available. Isolate the relocated Host test's CODEX_HOME.
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
N/A
Test plan
npm run lint：通过，含依赖边界检查。npm run typecheck：通过。npx vitest run --config tests/vitest.config.js packages/console-server/test packages/renderer-extension/test/console tests/release/npm-package.test.mjs：86 个测试通过。cargo fmt --all --check：通过。cargo test --locked --package codexhost-launcher：64 个测试通过。npm run build:renderer：通过。