fix(results): encode download filenames - #587
Open
bm1016bm-svg wants to merge 1 commit into
Open
Conversation
bm1016bm-svg
marked this pull request as ready for review
July 29, 2026 05:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encode the output filename as a single URL path segment before rendering preview and download links. This prevents
#from starting a fragment and also handles other reserved characters without changing the trusted user/job path segments.Validation
bun test: 100 passed, 8 skippedbun run lint:tscbun run lint:knipbun run buildCloses #578
Summary by cubic
Encode download filenames as a single URL path segment so preview and download links work with #, spaces, and Unicode. Path segments (e.g., user/job) remain unchanged.
buildDownloadUrlhelper to encode only the filename.Written for commit b9495de. Summary will update on new commits.