fix(dasel): update converter for v3 CLI - #591
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--var ... --out ...) instead of removed--file/--read/--writeflagsFixes #579.
Tests
PATH=/tmp/oss-pr-pipeline/convertx-579-tools/bin:$PATH bun test tests/converters/dasel.test.tsconvert()bun run lint:tscbun run lint:prettiergit diff --checkPATH=/tmp/oss-pr-pipeline/convertx-579-tools/bin:$PATH bun testSummary by cubic
Switch
daselconverter to v3 CLI flags (--var ... --out ... $data) and close stdin so v3 doesn't wait under Bun, fixing #579. Adds unit tests for argument generation and stdin handling.Written for commit 87ef3a0. Summary will update on new commits.