Skip to content

fix(dasel): update converter for v3 CLI - #591

Open
cyphercodes wants to merge 1 commit into
C4illin:mainfrom
cyphercodes:fix/dasel-v3-cli-579
Open

fix(dasel): update converter for v3 CLI#591
cyphercodes wants to merge 1 commit into
C4illin:mainfrom
cyphercodes:fix/dasel-v3-cli-579

Conversation

@cyphercodes

@cyphercodes cyphercodes commented Jul 30, 2026

Copy link
Copy Markdown

Summary

  • update the dasel converter to use the dasel v3 CLI (--var ... --out ...) instead of removed --file/--read/--write flags
  • close the child stdin pipe after spawning dasel so the v3 process does not wait for input under Bun
  • add unit coverage for the generated v3 arguments and stdin handling

Fixes #579.

Tests

  • PATH=/tmp/oss-pr-pipeline/convertx-579-tools/bin:$PATH bun test tests/converters/dasel.test.ts
  • real dasel v3.11.2 YAML→JSON smoke test through convert()
  • bun run lint:tsc
  • bun run lint:prettier
  • git diff --check
  • PATH=/tmp/oss-pr-pipeline/convertx-579-tools/bin:$PATH bun test

Summary by cubic

Switch dasel converter to v3 CLI flags (--var ... --out ... $data) and close stdin so v3 doesn't wait under Bun, fixing #579. Adds unit tests for argument generation and stdin handling.

Written for commit 87ef3a0. Summary will update on new commits.

Review in cubic

@github-actions github-actions Bot added Fix and removed Fix labels Jul 30, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dasel converter regression

1 participant