feat(importer): added new gobi importer - #1116
Open
callumlewis05 wants to merge 1 commit into
Open
Conversation
callumlewis05
force-pushed
the
new-importer-provider
branch
from
August 20, 2026 14:55
93a1cd8 to
0d2cfad
Compare
kpsherva
reviewed
Aug 25, 2026
kpsherva
reviewed
Aug 25, 2026
kpsherva
reviewed
Aug 25, 2026
| # CDS-ILS is free software; you can redistribute it and/or modify it under | ||
| # the terms of the MIT License; see LICENSE file for more details. | ||
| """CDS-ILS Gobi Importer ignore fields.""" | ||
| GOBI_IGNORE_FIELDS = { |
Contributor
There was a problem hiding this comment.
it is a bit ambiguous to know why some of these fields are ignored, is it reasonable to add some comments for each? In case we need to actually map any of them in the future
Contributor
|
To be verified: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new importer provider for GOBI marcxml.
Works with given test file.
Written to this specification to make it easier to review