Repository navigation
fix(seed): reject prod fixtures - #522
Merged
Merged
Conversation
Fixes #502 Signed-off-by: Simon van Lierde <90462640+simonvanlierde@users.noreply.github.com>
Merging this PR will not alter performance1 warning
Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This rejects fixture seeding in production before Alembic or Python can run. Fixes #502.
SEED_DUMMY_DATA=true, including mixed-case values, whenENVIRONMENT=prod.BULK_SEED_PRODUCTSwith the existing numeric condition.Tests: 305 stub checks, shell syntax, ShellCheck, shfmt and Markdown checks passed in a credential-free disposable container. The new rejection cases failed before the fix. No real database, production deployment, macOS or docs build was checked.
Type of change
Why
What problem does this solve?
Checklist
just ci)just test)