Repository navigation
change: reject transfers of the full balance (AccountService compareTo <= 0) - #336
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Garret Andreine <garret.andreine@cognition.ai>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
devin-ai-integration Bot
added a commit
that referenced
this pull request
Oct 23, 2026
…top) Co-Authored-By: Garret Andreine <garret.andreine@cognition.ai>
devin-ai-integration
Bot
deleted the branch
devin/1792723837-qa-playwright-e2e
October 23, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #332. A transfer that would leave the sender at exactly $0 is now rejected with
Insufficient funds.Only the transfer guard changes. Withdrawals (
withdraw) still allow taking out the full balance.This change conflicts with the plan. MT-040 in
qa/manual-test-plan.csvsays "Customer can transfer the full balance" and expects the sender at $0.00 and the recipient at $100.00. This PR leaves the plan and the MT-040 test as they are. If this rule is intended, someone needs to update MT-040's expected result. Locally against MySQL 8, MT-040 is the only row that fails (53 passed, 1 failed). The e2e check on this PR is expected to go red on MT-040.Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/4e5ce8a64e094b30882fb37f4f9983c5
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/4e5ce8a64e094b30882fb37f4f9983c5?variant=devin
Requested by: @GarretAnd
Devin Review